Fix incorrect delegation in diamond-shape case - #2978
Open
jku wants to merge 1 commit into
Open
Conversation
In a diamond delegation (where a role is delegated to from multiple delegating roles), if client has already verified a delegation through one branch and is now verifying the delegation through the other branch, it should still make sure the delegation is correctly signed via the second set of signers. The fix could be smaller and isloated in updater.py but I added the refactoring with `TrustedMetadataSet._add()` and `TrustedMetadataSet.contains()` to make this clearer. Fixes theupdateframework#2977 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a diamond delegation (where a role is delegated to from multiple delegating roles), if client has already verified a delegation through one branch and is now verifying the delegation through the other branch, it should still make sure the delegation is correctly signed with the second set of signers.
The fix could be smaller (and isolated in updater.py) but I added the refactoring with
TrustedMetadataSet._add()andTrustedMetadataSet.contains()to make this clearer.Fixes #2977
Test is ai generated, other code ai assisted.