Make role-based interactive views keyboard-focusable on iOS - #57822
Closed
fkgozali wants to merge 1 commit into
Closed
Make role-based interactive views keyboard-focusable on iOS#57822fkgozali wants to merge 1 commit into
fkgozali wants to merge 1 commit into
Conversation
Summary:
On iOS, Full Keyboard Access decides whether a Fabric view can take keyboard focus
from its UIKit accessibility trait mask. That mask is a lossy projection of the
`role` / `accessibilityRole` prop: `checkbox`, `radio`, `combobox`, `dropdownlist`,
`menuitem`, `spinbutton`, `tab`, and the ARIA `option`, `searchbox`, `slider` and
`treeitem` all resolve to no interactive trait, because VoiceOver conveys those
roles through `accessibilityValue` instead. Controls authored with any of them were
unreachable with a keyboard - a WCAG 2.1.1 (Keyboard) failure.
Derive focusability from the role as well as the trait mask. Behaviour is otherwise
unchanged: views that opt out of accessibility (`accessible={false}`) and views with
no interactive role stay unfocusable, VoiceOver is untouched (it keys off
`isAccessibilityElement`), and tvOS keeps its existing `focusable` path.
Changelog:
[iOS][Fixed] - Views with checkbox, radio, combobox, dropdownlist, menuitem, spinbutton, tab, option, searchbox, slider and treeitem roles are now reachable via Full Keyboard Access
Differential Revision: D114784056
meta-cla
Bot
added
the
CLA Signed
|
@fkgozali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114784056. |
|
This pull request has been merged in 05b97de. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On iOS, Full Keyboard Access decides whether a Fabric view can take keyboard focus
from its UIKit accessibility trait mask. That mask is a lossy projection of the
role/accessibilityRoleprop:checkbox,radio,combobox,dropdownlist,menuitem,spinbutton,tab, and the ARIAoption,searchbox,sliderandtreeitemall resolve to no interactive trait, because VoiceOver conveys thoseroles through
accessibilityValueinstead. Controls authored with any of them wereunreachable with a keyboard - a WCAG 2.1.1 (Keyboard) failure.
Derive focusability from the role as well as the trait mask. Behaviour is otherwise
unchanged: views that opt out of accessibility (
accessible={false}) and views withno interactive role stay unfocusable, VoiceOver is untouched (it keys off
isAccessibilityElement), and tvOS keeps its existingfocusablepath.Changelog:
[iOS][Fixed] - Views with checkbox, radio, combobox, dropdownlist, menuitem, spinbutton, tab, option, searchbox, slider and treeitem roles are now reachable via Full Keyboard Access
Differential Revision: D114784056