TSL: Generate native WGSL switch statement (#33548) - #33852
Open
ShiKirill wants to merge 1 commit into
Open
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Contributor
Author
Collaborator
|
@ShiKirill Thanks for the PR, it might take me a bit longer to do the analysis; there are some things in the conditional flow which I was working on in another PR that I’d like to resolve before merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #33548
Description
Switch()/Case()/Default()previously desugared into a nestedif / elsechain on everybackend. This adds a dedicated
SwitchNodethat emits a native WGSLswitchstatement on theWebGPU backend, while the WebGL backend keeps the equivalent
if / else if / elsefallback (GLSLbehaviour unchanged).
Case( 1, 2, 3, … )) generatecase 1, 2, 3:defaultclause is always emitted on WGSL (required by the spec)i32/u32) type of the switch expressionVerified identical rendering on both the WebGPU and WebGL backends for single/multi-value cases,
with and without a
Default().