fix(a2a): drop unparseable A2A metadata instead of aborting conversion - #1401
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix(a2a): drop unparseable A2A metadata instead of aborting conversion#1401copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
`ResponseConverter.parseMetadata` rethrew every deserialization failure as `IllegalArgumentException`, which propagated out of `taskToEvent`, `messageToEvent` and `handleTaskUpdate`. Because `adk_grounding_metadata`, `adk_usage_metadata`, `adk_custom_metadata` and `adk_error_code` are all peer-controlled, any A2A peer could deterministically fail the calling agent's turn with a single unparseable value. Log at WARN and drop the offending field instead, so auxiliary telemetry cannot take down the whole conversion. This reverses a contract that cl/881389811 pinned with `taskToEvent_withInvalidMetadata_throwsException`. That test is inverted rather than deleted so the behaviour change is explicit in review. The tradeoff is that `EventConverter` writes these same keys on the send side, so a parse failure can also mean our own serialization broke - that signal moves from an exception to a WARN log rather than disappearing. PiperOrigin-RevId: 958968673
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(a2a): drop unparseable A2A metadata instead of aborting conversion
ResponseConverter.parseMetadatarethrew every deserialization failure asIllegalArgumentException, which propagated out oftaskToEvent,messageToEventandhandleTaskUpdate. Becauseadk_grounding_metadata,adk_usage_metadata,adk_custom_metadataandadk_error_codeare allpeer-controlled, any A2A peer could deterministically fail the calling agent's
turn with a single unparseable value. Log at WARN and drop the offending field
instead, so auxiliary telemetry cannot take down the whole conversion.
This reverses a contract that cl/881389811 pinned with
taskToEvent_withInvalidMetadata_throwsException. That test is inverted ratherthan deleted so the behaviour change is explicit in review. The tradeoff is that
EventConverterwrites these same keys on the send side, so a parse failure canalso mean our own serialization broke - that signal moves from an exception to a
WARN log rather than disappearing.