Skip to content

fix: set base_form on form-locked evolutions - #1634

Open
MiquelRForgeFlow wants to merge 2 commits into
PokeAPI:masterfrom
MiquelRForgeFlow:master-fix-pikachu-evolution-base-form
Open

fix: set base_form on form-locked evolutions#1634
MiquelRForgeFlow wants to merge 2 commits into
PokeAPI:masterfrom
MiquelRForgeFlow:master-fix-pikachu-evolution-base-form

Conversation

@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

A few species only evolve from their default form, but their evolution rows in pokemon_evolution.csv left base_form empty (which reads as "any form"). This wrongly implies their permanent non-evolving alternate forms can also evolve:

  • Pikachu's cap / cosplay / partner / starter forms
  • Partner Eevee
  • Eternal Flower Floette

These forms are ordinary (not is_battle_only) and have no evolution row of their own, so nothing else disambiguates them. This PR sets base_form so only the default form evolves.

It also fixes Pumpkaboo → Gourgeist, which is size-preserving: the single trade evolution is split into four size-locked rows, each with base_form/evolved_form set so every Pumpkaboo size evolves into the Gourgeist of the same size (average/small/large/super).

Changes:

  • Pikachu → Raichu: base_form = pikachu on both the Kanto and Alola Raichu rows.
  • Eevee → eeveelutions: base_form = eevee on all Eeveelution rows.
  • Floette → Florges: base_form = floette.
  • Pumpkaboo → Gourgeist: four size-locked rows (average/small/large/super) with matching base_form/evolved_form.

AI coding assistance disclosure

Checking numbers and writing PR message.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

Pikachu, Eevee and Floette evolve only from their default form, but the
evolution rows left base_form empty — reading as "any form", which
implies their non-evolving forms (cap/cosplay/partner Pikachu, Partner
Eevee, Eternal Flower Floette) evolve too. Set base_form so only the
default form evolves.
Each Pumpkaboo size evolves into the Gourgeist of the same size
(average/small/large/super), so split the single trade evolution into
four size-locked rows instead of one unrestricted row.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants