fix: set base_form on form-locked evolutions - #1634
Open
MiquelRForgeFlow wants to merge 2 commits into
Open
Conversation
Pikachu, Eevee and Floette evolve only from their default form, but the evolution rows left base_form empty — reading as "any form", which implies their non-evolving forms (cap/cosplay/partner Pikachu, Partner Eevee, Eternal Flower Floette) evolve too. Set base_form so only the default form evolves.
Each Pumpkaboo size evolves into the Gourgeist of the same size (average/small/large/super), so split the single trade evolution into four size-locked rows instead of one unrestricted row.
jemarq04
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few species only evolve from their default form, but their evolution rows in
pokemon_evolution.csvleftbase_formempty (which reads as "any form"). This wrongly implies their permanent non-evolving alternate forms can also evolve:These forms are ordinary (not
is_battle_only) and have no evolution row of their own, so nothing else disambiguates them. This PR setsbase_formso only the default form evolves.It also fixes Pumpkaboo → Gourgeist, which is size-preserving: the single trade evolution is split into four size-locked rows, each with
base_form/evolved_formset so every Pumpkaboo size evolves into the Gourgeist of the same size (average/small/large/super).Changes:
base_form = pikachuon both the Kanto and Alola Raichu rows.base_form = eeveeon all Eeveelution rows.base_form = floette.base_form/evolved_form.AI coding assistance disclosure
Checking numbers and writing PR message.
Contributor check list