added fix for shakedown which was failing to decrypt - #224
Open
sgaddala-ks wants to merge 1 commit into
Open
Conversation
sgaddala-ks
requested review from
THeflinKeeper,
saldoukhov and
tylerccarson
as code owners
August 5, 2026 11:45
Contributor
|
I don't think we can accept this change as-is-- the whole reason we split up proto.js into modules was for the sake of tree-shaking (since they are so large combined). It also doesn't look like vault.ts actually references the newly imported protos ([NotificationCenter, Dag, Authentication, BreachWatch, Enterprise]). This looks like something to be fixed downstream where this package is being used, happy to help figure it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.